Closed KotRikD closed 3 years ago
I'll merge when I have regenerated the test suite but it looks good so far
Be careful, I was trying to generate a test suite yesterday, some scores still hasn't been recalculated on bancho.
I tried manually generating the test suite, but something broke. probably error on my end. As far as i know, bancho recalc for the top ~20k players has finished.
for context:
Traceback (most recent call last):
File "./download_suite.py", line 60, in <module>
unique_maps = set([s['beatmap_id'] for m in [0, 1] for s in scores[m]])
TypeError: string indices must be integers
after running gentest.py
@MaxKruse https://ghostbin.co/paste/ah52d I fixed this mistake here, try it!
But as I said before, some scores still not recalculated just comapre this
PP Recalc is done, packing is possible. Pre-packed: https://lithibae.s-ul.eu/8D5oqmLT
can confirm that 2153557 is still not recalculated as @KotRikD said, need to figure out how to generate a good enough test suite for now that doesn't include old scores
even if i pick pretty new maps there's still many scores that aren't recalced hmmm
if I include only the current top 10 or so's top plays the tests pass, let's use that as the temporary test suite
Hi! The PR is aimed at implementing the latest pp changes, I'm not a good C programmer, so I think there may be errors and improper formatting. Otherwise, tested on a couple of scores: