search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
155 stars 36 forks source link

Max combo calculation is incorrect? #71

Open natsukagami opened 3 years ago

natsukagami commented 3 years ago

This beatmap: https://osu.ppy.sh/beatmapsets/966062#osu/2022204 has 542 max combos (check scoreboard and osu! API)

But oppai currently reports 541 max combo:

❯ curl https://osu.ppy.sh/osu/2022204 | ./oppai -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 21978    0 21978    0     0  57836      0 --:--:-- --:--:-- --:--:-- 57685
The Cro-Magnons - Totsugeki Rock (ザ・クロマニヨンズ - 突撃ロック) [Sotarks no Jutsu] mapped by Sotarks

AR9.2 OD9.2 CS3.8 HP5.8
300 hitwindow: 24 ms
231 circles, 149 sliders, 0 spinners
6.46 stars (3.5 aim, 2.42 speed)

speed strain:  _ .--^ _.--^_  ._._-^.. -_...-^-----^^^^^_--^-
  aim strain: __ ..__ ___-^    ____-__ .__...^-----^^^^^_____

541/541x 100%
326.27 pp (172.92 aim, 59.07 speed, 86.72 acc)
natsukagami commented 3 years ago

More samples: https://osu.ppy.sh/osu/2459413 (max combo 1753)

❯ curl https://osu.ppy.sh/osu/2459413 | ./oppai -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 66988    0 66988    0     0   148k      0 --:--:-- --:--:-- --:--:--  148k
ReoNa - Till the End [Endless] mapped by Sotarks

AR9.2 OD8.7 CS3.8 HP5.2
300 hitwindow: 27 ms
728 circles, 465 sliders, 3 spinners
5.82 stars (3.09 aim, 2.36 speed)

speed strain:  ------.-..-- -..-- .^^-.....__.-_..-.-.--.---..-.
  aim strain:   _..^- ___-^_-..._ --. _...._ _^...-__-^^_.^-..._

1750/1750x 100%
304.35 pp (137.06 aim, 62.61 speed, 99.2 acc)
Francesco149 commented 3 years ago

yea if i remember correctly it's not 100% correct because it involves slider ticks but it's close enough usually