Incorrect AR<8 bonus in most (if not all) oppai ports

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai

The Unlicense

155 stars 36 forks source link

Closed Rian8337 closed 3 years ago

Rian8337 commented 3 years ago

should be

  /* low ar bonus */
  else if (ez->ar < 8.0f) {
    ar_bonus += 0.01f * (8.0f - ez->ar);
  }

Francesco149 commented 3 years ago

the 0.01 comes from a january commit. I don't think that change is live on leaderboards https://github.com/ppy/osu-performance/commit/60bc836c5ed0852c1807cb00c98f61c809838b17

Rian8337 commented 3 years ago

Didn't they claim the AR<8 buff overlooked as of https://github.com/ppy/osu/pull/11476, though?

Francesco149 commented 3 years ago

gotta check if live scores are already affected by this. if not i will merge it when they do