search

Francesco149 / oppai-ng

difficulty and pp calculator for osu!. better, smaller, faster rewrite of https://github.com/Francesco149/oppai
The Unlicense
155 stars 36 forks source link

Update PP calculation #82

Closed oSumAtrIX closed 2 years ago

oSumAtrIX commented 2 years ago

RE: #81

This PR updates oppai.c to calculate according to the latest pp changes.

Thanks to @l3lackShark

Francesco149 commented 2 years ago

all the code style changes are generating useless diff's and make it difficult to tell what actually changed. minimize the diff

oSumAtrIX commented 2 years ago

Should the commit be splitted into two, one for formatting and one for the pp update?

A default formatter should be introduced like ClangFormat.

Francesco149 commented 2 years ago

no code formatting changes pls

l3lackShark commented 2 years ago

@oSumAtrIX I have no idea how I contributed to this but if i somehow did - Thanks! Are you going to push these changes later? What was the reason to close the PR?

oSumAtrIX commented 2 years ago

@oSumAtrIX I have no idea how I contributed to this but if I somehow did - Thanks! Are you going to push these changes later? What was the reason to close the PR?

Thank you for your contribution. It seemed like the calculation was not correct.