FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
205 stars 49 forks source link

[develop] When using Index Action, Faded actions are inconsistent to each other #183

Open radiomike opened 5 years ago

radiomike commented 5 years ago

When using Index Action to fade cue, some fade types always use time and curve set in preferences while some always use time and curve set in cue.

Faded Start, Faded Resume, Faded Stop and Faded Pause use the in cue setting. Fade In, Fade Out and Faded Interupt use the preferences default

All fade/faded cues should use the preferences defaults unless an alternative is defined in the cue settings.

As a possible addition/enhancement, perhaps there should be an option in the cue settings to reset the fade time and/or curve to the preferences default

radiomike commented 5 years ago

Having considered this, perhaps a better way is this:

When media cues are created, they are assigned the current fade duration and curve from preferences. On applying changes to fade preferences user could be asked to also apply new preference settings to all existing cues, preferably with the option to select in/out duration and curves individually. Once new preference is applied any subsequently created cues use the new default. As in previous comment, it probably also makes sense to be able to reset to preference settings on a per cue level too.

Another alternative is to keep current way, but make it clearer in the naming of cue actions as to which fade duration or curve settings are used. This is less preferable, but might make sense as a temporary solution.

FrancescoCeruti commented 5 years ago

The behavior come from issue #33 and it was intentional, the "Fade Action" settings are not intended as a default, but as the actual value to be used. It's not very clear, I agree on that.

At this point I think the best approach is that "Fade Out" and "Fade In" actions should always use the cue default settings, if in need of a custom fade there's the Volume Control cue, also the cue can be instructed to start/pause/stop with or without a fade. There are plenty of options.

The fade triggered from the List Layout buttons can make use of the global setting, also giving some option on how they behave:

The only place where I'll keep the current behavior is the interrupt action. What do you think?