search

FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
205 stars 49 forks source link

Config changes require a reload #191

Closed paulbdavis closed 4 years ago

paulbdavis commented 4 years ago

Expected Behavior

I would expect the "Ok" button to save the config and apply it to the application immediately

Actual Behavior

The config options seem to only be loaded at startup, so any changed done via the UI require a restart to take effect

Step to reproduce

Start LiSP, change an option, observe change is not working, restart app, observe change is now in effect.

If it's difficult to implement this, a note next to the OK button would at least make it more obvious as to why settings have not changed yet (I first noticed it when I could not use my new go key binding until I restarted the app)

FrancescoCeruti commented 4 years ago

For now I'll add a note to make it clear, anyway I think most of the options could be applied directly, it's up to the components that use the specific value.

paulbdavis commented 4 years ago

This was related to the master branch, but develop has it's own issues with the config it seems (mentioned in my PR for the disable go key option)