FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
207 stars 49 forks source link

Don't use waveform slider when playing Media cues with "Preset" source #208

Closed s0600204 closed 3 years ago

s0600204 commented 3 years ago

Currently when a GstMediaCue added to a List Layout with the input of the cue's pipeline set to "Preset Input" is played, an error is emitted and the cue doesn't appear in the "Playing Cues" section. (A further error is emitted when the cue ends or is stopped.)

The initial error is emitted because the waveform code attempts to generate a waveform from the cue's media file, but the Preset Input is not sourced from one.

This PR checks that the cue has a file URI, and if not fallbacks to the other slider representation.

FrancescoCeruti commented 3 years ago

Thank you :)