FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
207 stars 49 forks source link

IndexAction cue have only one possible action #227

Closed Stav88 closed 2 years ago

Stav88 commented 2 years ago

Describe the bug IndexAction cue have only one possible action "Start'.

To Reproduce Steps to reproduce the behavior:

  1. Create à new "Index Action Cue" (Edit > Action cues > Index Action)
  2. Open the edit window of the cue (right click > Edit cue)
  3. Open the "Action settings" tab
  4. The action combobox has only one option Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Linux Show Player version:

OS Version

Additional context I have tried to fix the list in Cue class (lisp/cues/cue.py L125) :

diff --git a/lisp/cues/cue.py b/lisp/cues/cue.py
index 7aed52f2..8902a28d 100644
--- a/lisp/cues/cue.py
+++ b/lisp/cues/cue.py
@@ -122,7 +122,19 @@ class Cue(HasProperties):
     default_start_action = Property(default=CueAction.Start.value)
     default_stop_action = Property(default=CueAction.Stop.value)

-    CueActions = (CueAction.Start,)
+    CueActions = (
+        CueAction.Default,
+        CueAction.FadeIn,
+        CueAction.FadeOut,
+        CueAction.FadeInStart,
+        CueAction.FadeOutStop,
+        CueAction.FadeOutPause,
+        CueAction.FadeOutInterrupt,
+        CueAction.Interrupt,
+        CueAction.Start,
+        CueAction.Stop,
+        CueAction.Pause,
+    )

     def __init__(self, id=None):
         super().__init__()

The combo box is correctly displayed. I dont know and didn't test if all thoses actions work in usage of cue. I have tied only to use FadeOutStop, that's work.

s0600204 commented 2 years ago

The behaviour you are seeing is expected if the cue is pointing at itself.

Perhaps it would help if you could tell us what it is you're expecting this cue to actually do when you press "Go".

Stav88 commented 2 years ago

That is because I tried to isolate the bug. I did't see that it change when a change the index. But I have the same bug when I open a saved project or I uncheck the "relative" checkbox : image

To Reproduce (checkbox)

To Reproduce (form saved project)

s0600204 commented 2 years ago

Thank you for the more comprehensive reproduction instructions. I can now replicate the issue, and have filed a Pull Request (#228) with a fix.

FrancescoCeruti commented 2 years ago

Thank you all :)