FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
212 stars 49 forks source link

No MIDI timecode output #329

Open mmoomocow opened 2 months ago

mmoomocow commented 2 months ago

Describe the bug I have a cue set up with timecode enabled, but it doesn't output MIDI. LiSP does recieve MIDI notes, as I can trigger cues by sending MIDI notes from my lighting console (Hog4pc with timecode widget) but it isn't receiving timecode and the MIDI send lights on the interface flash. If I send a MIDI note from LiSP the interface's data send light does flash briefly.

To Reproduce Steps to reproduce the behavior:

  1. Setup MIDI to use USB interface
  2. Set timecode to SMPTE and MIDI & save
  3. enable midi on cue and set hour with track number
  4. trigger cue, Lighting console isn't recieving MIDI and the light on the USB interface isn't flashing.

Expected behavior MIDI timecode should be sent, and this should be noticeable as the data send light on the interface flashes.

Screenshots

Linux Show Player version:

OS Version

Additional context

FrancescoCeruti commented 2 months ago

You can try the master build, it should be fixed there.

mmoomocow commented 2 months ago

Have tested and appears to be sending now, although my lighting console can't interpret the MTC being sent. Is there a way I could specify the the framerate in LiSP and to send full messages instead of quarter?

I've got LiSP configured for timecode over MIDI using the SMPTE format, and Hog4PC is expecting SMPTE30 over midi

FrancescoCeruti commented 1 month ago

If you select SMPTE the format is 30 frame/sec (the rate at which messages are sent is always 30 per second).

Is there a way I could specify [...] to send full messages instead of quarter?

It needs to be implemented as an option, currently full messages are sent only when the cue starts and when it's seeked

mmoomocow commented 1 month ago

With some additional testing the issue appeared to be that it wasn't able to send send the packets quickly enough. It didn't appear to be throttled by resource usage, but I'm unsure if it is being throttled by my MIDI interface or not, but given that it's using quarter messages at 30 frames/sec I wouldn't be surprised if there are some limitations either in software or the MIDI hardware I am using.