FrancescoCeruti / linux-show-player

Linux Show Player - Cue player designed for stage productions
https://linux-show-player.org
GNU General Public License v3.0
212 stars 49 forks source link

Audio cues are trimmed sometimes with JACK #330

Open moonshaadow opened 1 month ago

moonshaadow commented 1 month ago

Describe the bug I have noticed that sometimes the attack of some audio cues are trimmed. The behavior happens when the cue is manually triggered.

To Reproduce Steps to reproduce the behavior:

  1. create a media cue. To easily hear the behavior, choose a very short audio file, with audio starting at the very beginning of the file.
  2. If this is not default behavior, choose JACK output for this cue.
  3. manually trigger the cue, many times until you hear the behavior. You should notice cut attack, sometimes. . Expected behavior Audio cue be played entirely, from the very beginning of the file.

Linux Show Player version:

OS Version

Additional context This is not happening with pure ALSA instead of JACK. So maybe it could happen because of the refreshing of JACK connections at each trig. This is not happening when we loop the cue.

FrancescoCeruti commented 1 month ago

So maybe it could happen because of the refreshing of JACK connections at each trig.

Very likely, currently the connection happens asynchronously, we need to block the playback while connecting