search

FrancescoSTL / Site-Sonar

A browser extension which silently crowd-sources ad performance as you browse. Let's put an end to bad ads.
http://site-sonar.com
Mozilla Public License 2.0
9 stars 2 forks source link

Mitigate when data is too large to send (>15mb) #54

Closed FrancescoSTL closed 7 years ago

FrancescoSTL commented 7 years ago

The dashboard is now updated so that it accepts data up to 15mb. We should probably be checking client-side to make sure the string isn't larger than that, because if it is, users will have a growing Map which could increase in size indefinitely. While the likelyhood a user gets 15mb worth of asset logs in 2 min is astronomically low (that would require loading >36,000 ad-asset records), we should probably make sure it isn't happening.

Reference to finding: https://github.com/FrancescoSTL/Ultra-Lightbeam/issues/43

FrancescoSTL commented 7 years ago

This is a non-issue, especially because we are only grabbing 1/10th of all user benchmarks to POST anyway.