Closed kleinicke closed 2 years ago
Merging #304 (6e4974d) into master (bbd8e7c) will decrease coverage by
1.47%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 97.23% 95.75% -1.48%
==========================================
Files 82 86 +4
Lines 2998 3085 +87
==========================================
+ Hits 2915 2954 +39
- Misses 83 131 +48
Impacted Files | Coverage Δ | |
---|---|---|
glasses/__init__.py | 100.00% <ø> (ø) |
|
glasses/models/AutoModel.py | 90.00% <ø> (+11.27%) |
:arrow_up: |
glasses/models/AutoTransform.py | 100.00% <ø> (ø) |
|
glasses/models/base/__init__.py | 100.00% <ø> (ø) |
|
glasses/models/base/protocols.py | 100.00% <ø> (ø) |
|
glasses/models/classification/deit/__init__.py | 100.00% <ø> (ø) |
|
glasses/models/classification/densenet/__init__.py | 100.00% <ø> (ø) |
|
...ses/models/classification/efficientnet/__init__.py | 99.31% <ø> (+0.06%) |
:arrow_up: |
glasses/models/classification/fishnet/__init__.py | 100.00% <ø> (ø) |
|
...lasses/models/classification/mobilenet/__init__.py | 100.00% <ø> (ø) |
|
... and 110 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 75871bd...6e4974d. Read the comment docs.
Thanks for the PR, test coverage is decreased maybe we can have a look :)
What does the codecov score exactly mean? Replacing a list as the default value by none
if num_pools is None:
num_pools = [1, 4, 16]
decreased the score of the file SpatialPyramidPool.py by 5%. Is this because num_pools is defined in every test, so the default value is never used?
@kleinicke I think you are right
@kleinicke thanks for working on this
Reduced the number of pylint warnings. I hope, I didn't break anything (for me everything works as before)