FrancescoXX / 4c-site

Open-source website for the 4C
https://4c.rocks
MIT License
218 stars 155 forks source link

[Feat]:Navigation bar #653

Closed CBID2 closed 11 months ago

CBID2 commented 1 year ago

Description

When I first saw the website, I want to know more about the origin of this community, and who are the top creators. Sadly, I couldn’t find information on that.

Solution

I think it’d be beneficial for the website to have a navigation bar with sections based on the information that I mentioned in the Description section. It’ll make it easier for new members to learn about 4C and make the website’s design look more appealing.

Anything else?

Navigation bar inspiration

Code of Conduct

tobySolutions commented 1 year ago

Are you still working on this @CBID2? I see that you've made tremendous progress on this.

Slowly, but yes

Awesome!! That's nice to hear. I'll see if I can get someone that has a good handling of Javascript to work with y'all!

CBID2 commented 1 year ago

Are you still working on this @CBID2? I see that you've made tremendous progress on this.

Slowly, but yes

Awesome!! That's nice to hear. I'll see if I can get someone that has a good handling of Javascript to work with y'all!

Thanks

tobySolutions commented 1 year ago

Sure thing @CBID2!!!

lambeboluwatife commented 1 year ago

Something like this right @CBID2 Screenshot (60)

CBID2 commented 1 year ago

Something like this right @CBID2

Screenshot (60)

Yes! Perfect @lambeboluwatife

lambeboluwatife commented 1 year ago

Something like this right @CBID2

Screenshot (60)

Yes! Perfect @lambeboluwatife

okay can I push it?

tobySolutions commented 1 year ago

Awesome job @lambeboluwatife!!

tobySolutions commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

lambeboluwatife commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

nope just gave it a background color

CBID2 commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

nope just gave it a background color

Great @lambeboluwatife! Can you link your entry here so I can push? I'll add your name to the PR

lambeboluwatife commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

nope just gave it a background color

Great @lambeboluwatife! Can you link your entry here so I can push? I'll add your name to the PR

how do I do that?

tobySolutions commented 1 year ago

Hey @CBID2 and @lambeboluwatife, how's this going?

CBID2 commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

nope just gave it a background color

Great @lambeboluwatife! Can you link your entry here so I can push? I'll add your name to the PR

how do I do that?

@lambeboluwatife: Linking a PR to an issue

tobySolutions commented 1 year ago

Great job @CBID2!!

lambeboluwatife commented 1 year ago

I hope you checked the stacking context of the header with (z-index) and used position: sticky, to make the UX of navbar good @lambeboluwatife?

nope just gave it a background color

Great @lambeboluwatife! Can you link your entry here so I can push? I'll add your name to the PR

how do I do that?

@lambeboluwatife: Linking a PR to an issue

thanks

lambeboluwatife commented 1 year ago

https://github.com/FrancescoXX/4c-site/compare/main...lambeboluwatife:4c-site:feat-nav-bar-653?expand=1 @CBID2

CBID2 commented 1 year ago

https://github.com/FrancescoXX/4c-site/compare/main...lambeboluwatife:4c-site:feat-nav-bar-653?expand=1 @CBID2

Made the PR. @tobySolutions, can you put our names in Assigne section please? I tried doing it on my own but it won’t let me.

tobySolutions commented 1 year ago

Awesome! I'll do that now Chrissy @CBID2. Thanks for the amazing work.

tobySolutions commented 1 year ago

You both are already assigned to this issue @CBID2. What do you mean? One thing I noticed is that you didn't link this isue to your PR.

lambeboluwatife commented 1 year ago

You both are already assigned to this issue @CBID2. What do you mean? One thing I noticed is that you didn't link this isue to your PR.

I tried doing that but I didn't get it

tobySolutions commented 1 year ago

Oh @lambeboluwatife, you can actually press the "#" to see a dropdown of issues that you can link to. What do you think?

tobySolutions commented 1 year ago

Hey @CBID2!! The background image breaks on desktop screens.

image

CBID2 commented 1 year ago

Hey @CBID2!! The background image breaks on desktop screens.

image

Ooh how can we fix it @tobySolutions

tobySolutions commented 1 year ago

Awesome!! I already reverted the commit anyways, Please feel free to make a new PR.

CBID2 commented 1 year ago

Awesome!! I already reverted the commit anyways, Please feel free to make a new PR.

Ok

lambeboluwatife commented 1 year ago

Awesome!! I already reverted the commit anyways, Please feel free to make a new PR.

Ok

can you do this @CBID2

CBID2 commented 1 year ago

Awesome!! I already reverted the commit anyways, Please feel free to make a new PR.

Ok

can you do this @CBID2

I can try

tobySolutions commented 1 year ago

Awesome @CBID2. Please make sure to take your time with this issue, no pressure.

CBID2 commented 1 year ago

Awesome @CBID2. Please make sure to take your time with this issue, no pressure.

Hey @tobySolutions. Are you ready to merge this?

tobySolutions commented 1 year ago

Thanks for reaching out @CBID2!! I need to check out out again on Desktops view to see if the issue has been fixed. The issue with the Nav black background not spanning the entire screen.

Thanks once again for reaching out. We need to settle this once and for all already! 🚀🚀

tobySolutions commented 1 year ago

You guys are doing great @CBID2, @lambeboluwatife!!

CBID2 commented 1 year ago

Does that mean it can be merged now @tobySolutions?

tobySolutions commented 1 year ago

Hey @CBID2! No, not yet. The issue hasn't been totally resolved yet. If you could see what the nav looks like on my screen, you'd understand. The background and layout of the nav just needs some adjustments.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 0.16.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

avi9prasad commented 1 year ago

i want to work on this please assign it to me

tobySolutions commented 1 year ago

Sure thing @avi9prasad!!

nitin-pandita commented 1 year ago

I have a great idea for the navbar, would like to work on it

CBID2 commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

nitin-pandita commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it? Screenshot 2023-04-30 153139 Like this

CBID2 commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

Screenshot 2023-04-30 153139

Like this

That could work! :)

nitin-pandita commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

Screenshot 2023-04-30 153139 Like this

That could work! :)

Great, Please assign me the issue and I will start working on it

CBID2 commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

Screenshot 2023-04-30 153139

Like this

That could work! :)

Great, Please assign me the issue and I will start working on it

@tobySolutions, can you assign this issue to @nitin-pandita please?

tobySolutions commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

Screenshot 2023-04-30 153139

Like this

That could work! :)

Great, Please assign me the issue and I will start working on it

@tobySolutions, can you assign this issue to @nitin-pandita please?

Sure thing. Should I assign you both?

nitin-pandita commented 1 year ago

I have a great idea for the navbar, would like to work on it

Sure what is it?

Screenshot 2023-04-30 153139

Like this

That could work! :)

Great, Please assign me the issue and I will start working on it

@tobySolutions, can you assign this issue to @nitin-pandita please?

Sure thing. Should I assign you both?

I am up for it🎉

tobySolutions commented 1 year ago

Done! @nitin-pandita and @CBID2!

CBID2 commented 1 year ago

Thanks @tobySolutions! :) @nitin-pandita, how about you do your PR & I can add my suggestions in my review of it?

nitin-pandita commented 1 year ago

Thanks @tobySolutions! :) @nitin-pandita, how about you do your PR & I can add my suggestions in my review of it?

sure thing

tobySolutions commented 1 year ago

Perfect!!

tobySolutions commented 1 year ago

Any updates on this!!!

CBID2 commented 1 year ago

Any updates on this!!!

Still waiting for @nitin-pandita @tobySolutions