search

FrancescoXX / rustcrab

An Open Source project with everything you need to learn about Rust.
https://rustcrab.com
MIT License
402 stars 69 forks source link

navbar issue fixed and some minor issue fixed #112

Closed devvsakib closed 1 month ago

devvsakib commented 2 months ago

Description

Navar is now showing in every page. Changes some minor UI in People, DSA secttion

Closes #70

Summary by CodeRabbit

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rustcrab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 3:55am
coderabbitai[bot] commented 2 months ago

Walkthrough

The changes include integrating navigation components (Header, Footer, and CookieConsent) into the main layout, refining section rendering within the Home component, and updating styling in various sections. Navigation functionality is improved by replacing section setting with direct links, ensuring smoother user experience across pages.

Changes

File Change Summary
src/app/globals.css Consolidated the transition property and added scroll-behavior: smooth.
src/app/layout.tsx Added imports and included Header, Footer, and CookieConsent components in RootLayout function.
src/app/page.tsx Removed renderSection function, directly rendered specific sections, reorganized main content layout.
src/components/DSASection.tsx Removed dark:bg-gray-800 and changed bg-gray-100 to bg-gray-200.
src/components/DevToolsSection.tsx Changed CSS class from py-16 to min-h-dvh.
src/components/Header.tsx Removed setSection prop, added Link component for home navigation.
src/components/LessonSection.tsx Removed dark:bg-gray-800 bg-gray-200 classes, changed bg-gray-100 to bg-gray-200.
src/components/PeopleSection.tsx Modified CSS class from dark:bg-gray-900 bg-gray-100 to dark:bg-gray-900 bg-gray-200.
src/components/ProjectsSection.tsx Replaced direct project info rendering with Card component reference.
src/components/navbar/MobileNav.tsx Updated imports, modified menu items with new links, removed setSection and used Link components.
src/components/navbar/Navbar.tsx Updated menuItems links to include internal link format, removed NavbarProps and refactored component.

Assessment against linked issues

Objective Addressed Explanation
Navigation is present in all pages (#70) ✅

Poem

In code's quiet warren, changes through, Navigation paths, refreshed anew. Smooth scrolls and headers, all complete, A rabbit's joy in lines so neat. Pages now with links, not section set, A better user journey, you'll not forget.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
FrancescoXX commented 1 month ago

Thank you for this PR @devvsakib

Conceptually i like the idea of the scroll, but I want to put another newsletter form at the end and see if it converts (now it's converting very well since is the only CTA)

If I see a massive drop in the subs we might get back

devvsakib commented 1 month ago

okay @FrancescoXX