search

FrancescoXX / rustcrab

An Open Source project with everything you need to learn about Rust.
https://rustcrab.com
MIT License
420 stars 87 forks source link

The people section looks too clumsy #148

Closed felixoder closed 1 month ago

felixoder commented 3 months ago

https://github.com/user-attachments/assets/64196353-fedd-48fd-ba96-cb4439c23b02

As you can see for the small devices it looks decent but may be for large and medium devices it is looking like very tiny

tusharkaran commented 3 months ago

is this fixed ? Can i work on this ?

FrancescoXX commented 3 months ago

yes

tusharkaran commented 3 months ago

do you have any design , how should i implement any larger device ? any idea can you suggest me for the design ?

felixoder commented 3 months ago

Just see that in a larger device the content takes some grid view (eg, 2 comp in a grid-col) but here the width is too tiny of the people content. ref:

https://github.com/user-attachments/assets/502523d7-8996-4abe-ab56-51bf64deb571

you can fix the grid layout to fix this.

The main thing is you have to increase the width of the comp

[and also make sure that when there will be multiple person it will not damage the responsiveness]

*you can manually add some demo people to fix that

tusharkaran commented 3 months ago

got it . will fix this

tusharkaran commented 3 months ago

screen-capture.webm

does this look good , if it is ohk , will create pull request .

tusharkaran commented 3 months ago

shall i create pull request ?

FrancescoXX commented 1 month ago

we are remiving the people section for now, but thanks