search

FrancisCrickInstitute / AIoD-Model-Registry

The core registry for all AI models available on AI on Demand
0 stars 0 forks source link

Verify GitHub Actions run on PRs #3

Closed JonathanCSmith closed 9 months ago

JonathanCSmith commented 9 months ago

As title

sea-shunned commented 9 months ago

The action was run as part of PR #1 (specific run link), but may want to run it with another user?

JonathanCSmith commented 9 months ago

I want to confirm / ensure that having run these tests is a visual blocker for PR merging in the github PR interface. I have no reason to doubt that this will work automatically, but it needs confirmation :D

JonathanCSmith commented 9 months ago

I think our organisation github account may not allow this.... :'( I'm investigating.

sea-shunned commented 9 months ago

I presumed you meant if someone submitted a PR that doesn't pass, then the PR could not be merged? Didn't realise there was something in the settings for this...

Happy to test it by submitting a wrong PR if needed!

JonathanCSmith commented 9 months ago

Exactly that! I've contacted our account admin to see if it is a feature we have :D

nickynw commented 9 months ago

Hi both, I implemented this for a personal project, its in project Settings, then branches, branch protection rules, tick require status checks before merging, status checks will reflect the names of the actions run within the github action / workflow yml, i have this branch protection on the my 'main' branch, so this status checks only are reqired to pass when merging into that branch

JonathanCSmith commented 9 months ago

@nickynw thanks for this! I wonder why the information I found didn't point to this possibility at all!!!

JonathanCSmith commented 9 months ago

Closed by #6