search

FrancisCrickInstitute / TWOMBLI

A ImageJ Plugin implementation of TWOMBLI
0 stars 1 forks source link

Feature/pluginify #1

Closed JonathanCSmith closed 2 months ago

JonathanCSmith commented 7 months ago

First pass rewrite of TWOMBLI as a Java Plugin.

djpbarry commented 3 months ago

Hi @JonathanCSmith,

I've done some testing on this and I think everything is almost running as it should be. There's one major issue so far as I can see and it's related to the handling of outputs from the multiple runs of AnaMorf. Essentially, a lot of those outputs are not being included in the final results summary.

I've traced the problem to here: https://github.com/FrancisCrickInstitute/TWOMBLI/blob/6708a7e3010be18dda011f4a7632c08d605a2ff3/src/main/java/uk/ac/franciscrickinstitute/twombli/TWOMBLIRunner.java#L141-L145

In the above, the results from the AnaMorf runs are being overwritten without being summarised, so they never appear in the final TWOMBLI summary file.

JonathanCSmith commented 3 months ago

Thanks @djpbarry I'll work on these over the next two weeks. I'll also try and get some of the issues fixed at the same time.