search

FrancisG-Massey / Capstone2016

4 stars 0 forks source link

Email addresses as usernames? #208

Closed FrancisG-Massey closed 7 years ago

FrancisG-Massey commented 7 years ago

Rather than needing to remember a username, should we be creating new user accounts with email addresses as their usernames? I know we discussed this ages ago, but we should confirm here and make sure the web/app use consistent terminology (currently, the app uses "email address"/"password" while web uses "username"/"password").

The API doesn't care what gets submitted as the "username" field, so this affects web (the "volunteer" page and login screen) and the app (login screen).

sam-hunt commented 7 years ago

The API has a separate field in the user table for storing emails IIRC. We could disallow @ symbols in usernames, and then allow logging in with both maybe? I don't know what the best solution for this is.

Removing the field and using emails as the unique login identifier only is also an option, but more restricting.

ZoeUdy commented 7 years ago

API : API login needs to use use email instead of username @samhunt0 WEB : username label needs to be changed to email @MrMJLee

MrMJLee commented 7 years ago

Changed "Username" text to "Email" in the login form.

ZoeUdy commented 7 years ago

New issue regarding @samhunt0 responsibilities for API changes #237