FrancisTR / Rhythm-Swipe

A Repository dedicated to the 2D Game "Rhythm Swipe".
https://projectrhythmswipe.netlify.app/
GNU Affero General Public License v3.0
2 stars 0 forks source link

alpha v1.1.0: Major sync improvements #40

Closed FrostyNick closed 11 months ago

FrostyNick commented 11 months ago

Fixed #35 Fixed #36 ded91ed In-progress #42 56803f7

Specifically ticked off from #35:

New pause screen recently:

PR can wait / be merged with another update. Or it can be a separate update.

netlify[bot] commented 11 months ago

Deploy Preview for projectrhythmswipe ready!

Name Link
Latest commit b8aab734512cae946ea6e10443e21fe42bf5f177
Latest deploy log https://app.netlify.com/sites/projectrhythmswipe/deploys/64c054b6f5cf3e00080ce5ad
Deploy Preview https://deploy-preview-40--projectrhythmswipe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

FrancisTR commented 11 months ago

@FrostyNick There is going to be a massive update on the page and the game altogether. We are going to be in the Alpha Stage of v1.0.0. A PR will come in later this weekend. After that PR is merge, please do update anything on this PR to align with the new updated game and website.

FrostyNick commented 11 months ago

100% synced title is a bold statement.. there's always something that messes up sync :eyes:

New bugs in theory with tempo changing in it's current state:

Bug:

If there was a way to move to a specific part of the song to test this, and it stays synced, then it should be synchronized enough.

FrostyNick commented 11 months ago

New bugs found in this PR today:

I've passed about 9 rounds, it seems stable otherwise. This PR should be more stable before being accepted.

FrostyNick commented 11 months ago

I haven't seen any of the bugs above in the last 50 tests so far (mostly on Hard and Master). In theory the bugs above are fixed as of the previous commit, but it could not be reproduced. So no guarantee. There are extra logs if it ever does happen.

FrostyNick commented 11 months ago

Will merge when I get home or before leaving. Also only five merges to fix that's pretty minimal!

FrostyNick commented 11 months ago

Version is v1.1.0 can be changed to v1.0.0 if that is better

FrostyNick commented 11 months ago

Everything looks good! For the Pause button, I am able to still move my character. This will causes problems if the player dies while in pause mode. If you remove the ability to move when the game is paused, I believe everything is good!

Once that is finish, feel free to merge the PR once everything is finish on your end of course!

I can already tell why that is happening; related to typo with merge. I will check that everything works as intended and remove extra comments before merging.