search

FrancisTR / Rhythm-Swipe

A Repository dedicated to the 2D Game "Rhythm Swipe".
https://projectrhythmswipe.netlify.app/
GNU Affero General Public License v3.0
2 stars 0 forks source link

Misson success text not visible #50

Closed FrostyNick closed 1 year ago

FrostyNick commented 1 year ago

Describe the bug "M i s s i o n S u c e s s" as shown in the code is not completely visible with font 50 on my device. Maybe it's rendering differently on different devices, but I haven't been able to make it visible on other browsers or by zooming in and out.

To Reproduce Steps to reproduce the behavior:

  1. Go to main menu
  2. Go to dropdown menu, click Inspect and make sure you're on the "Console" tab in browser
  3. Type "level = 4"
  4. See error

Expected behavior The text should be visible.

Screenshots image

Desktop (please complete the following information):

FrancisTR commented 1 year ago

@FrostyNick That's odd. It shows up on mine perfectly fine. I did change it back since I was confused to why the number of the size changed. What browser are you using?

FrostyNick commented 1 year ago

This shows up on Firefox. And doesn't show up on Brave. image The different shade on Brave is caused by browser plugin Dark Reader ignore that.

FrostyNick commented 1 year ago

Bonus: Google Chromium image

This seems like Firefox engine difference with white spaces. One simple solution could be to center the text like is currently being done in the hidden experimental pause screen, although "M i s s i o n - S u c c e s s" will seem too big on Firefox still.

FrancisTR commented 1 year ago

This shows up on Firefox. And doesn't show up on Brave. image The different shade on Brave is caused by browser plugin Dark Reader ignore that.

I tested in Firefox and tried to recreate the error, but everything seems fine on my end.

FrostyNick commented 1 year ago

This shows up on Firefox. And doesn't show up on Brave. image The different shade on Brave is caused by browser plugin Dark Reader ignore that.

I tested in Firefox and tried to recreate the error, but everything seems fine on my end.

Interesting.. I decided to test Firefox on a few other systems. Uwuntu = Linux [distro]

Screenshots ![image](https://github.com/FrancisTR/Rhythm-Swipe/assets/57016218/ac57d060-f859-4fea-9bf3-fc6b22f87389) ![image](https://github.com/FrancisTR/Rhythm-Swipe/assets/57016218/d952978f-a0d8-4117-af67-a63bb0f4514c) I forgot to put a screenshot from my Android 11 phone. But basically, same result as Windows 11 above.

Seems like a Linux + Firefox issue. I will look for a solution right now

FrostyNick commented 1 year ago

Changing the font seems to make the white space consistent. 86f13eae0cabd46107a83534dbbff40be70d3fa4

Screenshots Linux + Firefox ![Linux](https://github.com/FrancisTR/Rhythm-Swipe/assets/57016218/a522f7e3-a381-427a-85b2-7be1fae7a5b0) Linux + Brave ![image](https://github.com/FrancisTR/Rhythm-Swipe/assets/57016218/942357bb-ab8b-4233-8524-513f690a5b4e) Linux + Chromium ![image](https://github.com/FrancisTR/Rhythm-Swipe/assets/57016218/b7be488b-9b61-47c4-b012-a9bcdbe78563)
FrancisTR commented 1 year ago

If you can add this font and readjust it accordingly in a new PR, that would be awesome! Like the new look!

FrostyNick commented 1 year ago

I can do that today. More info in PR.