FrancisTheCat / Window_Title_Bar_Remover

Simple Cli App to remove the default title bar from a window, matching name, classname or filename
GNU General Public License v3.0
2 stars 0 forks source link

How to build it #1

Closed Lol-Lap closed 10 months ago

Lol-Lap commented 10 months ago

I'm having a hard time trying to build it but I get this link.exe not found

FrancisTheCat commented 10 months ago

Hm, havent seen that before, Id recommend assuring that you installed odin correctly and if you still cant resolve the issue join the odin discord server and ask for help there.

FrancisTheCat commented 10 months ago

Btw installing via scoop worked flawlessly for me, but I didnt run into issues compiling from source either

FrancisTheCat commented 10 months ago

Have you got a working version of VisualStudio installed? https://odin-lang.org/docs/install

FrancisTheCat commented 10 months ago

Just added a release with binaries, hope that helps

Lol-Lap commented 10 months ago

Just added a release with binaries, hope that helps

That did help. Thank you. but I'm having another problem It just doesn't work. I don't know why I pasted the exact same command you had in glaze issue.

  - command: "exec 'C:/Users/Yanking Glyph/Downloads/title_remover_v0.0.1.exe' title regex Control Panel.*"
    match_title: "Control Panel.*"

and still I do nothing.

FrancisTheCat commented 10 months ago

You need to add quotations around the last argument like so: ... regex 'Control Panel.' Also im not sure this regex will match a window with the title "Control Panel", you might have to remove the .\ idk i dont know regex too well. The issue could also be that the control panel is in admin mode. Ill add some debug output to the program tomorow to pin issues like this down

Lol-Lap commented 10 months ago

You need to add quotations around the last argument like so: ... regex 'Control Panel.' Also im not sure this regex will match a window with the title "Control Panel", you might have to remove the . idk i dont know regex too well. The issue could also be that the control panel is in admin mode. Ill add some debug output to the program tomorow to pin issues like this down

Cool, It's for me, not just for the control panel. It's for everything it's not working. That was an example.

Lol-Lap commented 10 months ago

What should I try on that you know It's working 100%.

FrancisTheCat commented 10 months ago

Minecraft, Minecraft launcher :) and Cactus Image viewer. For testing you could also try it on the file explorer, wich wont work but clearly break

Lol-Lap commented 10 months ago

Minecraft, Minecraft launcher :) and Cactus Image viewer. For testing you could also try it on the file explorer, wich wont work but clearly break

  - command: "exec 'C:/Users/Yanking Glyph/Downloads/title_remover_v0.0.1.exe' title exact 'This PC'"
    match_title: "This PC"

That didn't work 😔

FrancisTheCat commented 10 months ago

Oh damn I remember, glaze changes args to lowercase, could you try using the cli directly?

Lol-Lap commented 10 months ago

It executes but does nothing image

Lol-Lap commented 10 months ago

The terminal opens, then closes fast when I reopen it.

FrancisTheCat commented 10 months ago

Ill add some debug output tomorrow but im off for now, sorry its almost midnight where I live

Lol-Lap commented 10 months ago

Ill add some debug output tomorrow but im off for now, sorry its almost midnight where I live

I'm so sorry. I didn't know that. Have a good night.

FrancisTheCat commented 10 months ago

Added a new release wich contains some basic logging, if you can send me the log.txt, I'll hopefully be able to help you

Lol-Lap commented 10 months ago

Added a new release wich contains some basic logging, if you can send me the log.txt, I'll hopefully be able to help you

Well, the WhatsApp One didn't remove the title bar, but it made the border wider, filling the screen.

[INFO ] --- [2024-01-12 16:23:13] [main.odin:91:main()] Criterium: Title
[INFO ] --- [2024-01-12 16:23:13] [main.odin:92:main()] Match Mode: Exact
[INFO ] --- [2024-01-12 16:23:13] [main.odin:93:main()] Arg: WhatsApp
[INFO ] --- [2024-01-12 16:23:13] [main.odin:100:main()] Found matching window: WhatsApp
[INFO ] --- [2024-01-12 16:23:13] [main.odin:102:main()] Removed title bar from window
FrancisTheCat commented 10 months ago

Yeah well thats to be expected, it is a custum title bar, wich cant really be removed easily. Also all windows will be bigger by 7 pixels, idk why, I just use resize borders to fix it. But Im assuming it works for the Control Panel now?

Lol-Lap commented 10 months ago

Yeah well thats to be expected, it is a custum title bar, wich cant really be removed easily. Also all windows will be bigger by 7 pixels, idk why, I just use resize borders to fix it. But Im assuming it works for the Control Panel now?

Yeah, so how to use it in glazewm config

FrancisTheCat commented 10 months ago

Yeah well thats to be expected, it is a custum title bar, wich cant really be removed easily. Also all windows will be bigger by 7 pixels, idk why, I just use resize borders to fix it. But Im assuming it works for the Control Panel now?

Yeah, so how to use it in glazewm config

Well thats another can of worms, I hacked glaze by removing the both occurences of .ToLowerInvariant() right here: https://github.com/glzr-io/glazewm/blob/e7d3732eb834407f416a50d112ae4a40b7710d6d/GlazeWM.Domain/UserConfigs/CommandParsingService.cs#L55 This is a hack and im sure it breaks some stuff, but I've decided I dont care as long as it works.