Error thrown by getUserFarmPosition in 1.2.23

[aantia]

I just updated the sdk to 1.2.23, and I'm now seeing an error when I call FranciumSDK.getUserFarmPosition(Web3.PublicKey). The error is UnhandledPromiseRejectionWarning: Error: Number can only safely store up to 53 bits. which I've seen when trying to convert overly-large BNs to Numbers, but it's being thrown before I actually touch any of the data. Here's the full trace:

(node:23064) UnhandledPromiseRejectionWarning: Error: Number can only safely store up to 53 bits
    at assert (D:\Programs\VSCode_projects\francium_interactor\node_modules\bn.js\lib\bn.js:6:21)
    at BN.toNumber (D:\Programs\VSCode_projects\francium_interactor\node_modules\bn.js\lib\bn.js:547:7)
    at formatFarmUserPosition (D:\Programs\VSCode_projects\francium_interactor\node_modules\francium-sdk\dist\utils\formatters\farm.js:8:32)
    at D:\Programs\VSCode_projects\francium_interactor\node_modules\francium-sdk\dist\main\index.js:62:62
    at Array.map (<anonymous>)
    at FranciumSDK.<anonymous> (D:\Programs\VSCode_projects\francium_interactor\node_modules\francium-sdk\dist\main\index.js:60:38)
    at Generator.next (<anonymous>)
    at fulfilled (D:\Programs\VSCode_projects\francium_interactor\node_modules\francium-sdk\dist\main\index.js:5:58)  
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

[aantia]

Sorry, I had a mental glitch and closed this incorrectly.

Updated information: The error occurs in utils/formatters/farm.js, on line 8. The problem is in the expression 'totalShares.toNumber() === 0'; this only works if totalShares (which is a BN) is small enough to represent in 53 bits.

[aantia]

Replace the line with this and it'll work (it's a bit ugly, though):

const userLP = totalShares.length < 2 ? (totalShares.toNumber() === 0 ? 0 : userShares.mul(totalLP).div(totalShares)) : userShares.mul(totalLP).div(totalShares);

[DFL-Levi]

Thanks! This solution helped me too.

[DFL-Levi]

@aantia maybe you can make pr on this issue.

[missrhyme]

fixed in 1.2.30

[DFL-Levi]

Thank you!