search

FrancoisMentec / PoE-Impact-Trading

A browser extension that show you the impact an item has on your build.
55 stars 6 forks source link

Support POB build code or pastebin instead of pob.party #10

Open lukezamboni opened 3 years ago

lukezamboni commented 3 years ago

We can't use pob.party since it is based on POB 2.3.0. Changes to the skill tree make it so builds are not importable anymore.

FrancoisMentec commented 3 years ago

I already tried, but I failed at making PoB works in a browser like pob.party is doing. Apparently, they use a Lua interpreter in C that runs PoB which is then compiled in web assembly. I tried to do the same but failed. So unless someone more skilled than me in C, lua and web assembly manage to make it works, the only thing we can do is to wait for pob.party to be fixed. Sorry.

lukezamboni commented 3 years ago

Got it! Thanks a lot for the answer anyways.

It's a shame we can't directly harass someone to get pob.party updated hahaha. Feel free to close the issue to no clutter the repo if you want.

wayperz commented 3 years ago

how to contact pob.party the software developers to update the version?

FrancoisMentec commented 3 years ago

how to contact pob.party the software developers to update the version?

I wish I knew. I have no idea who they are :-(

Zevell commented 2 years ago

Sorry to necro, but what about creating a desktop application to interact with PoB instead? I'm sure many people would be happy to run a desktop application to get significantly faster results.

Realistically; the desktop app would pull data from PoB (likely the save files) and then host a server for the browser extension to pull data from like an API. This may be too much work for what it's worth, but it would certainly be easier than attempting to re-write pob.party.

FrancoisMentec commented 2 years ago

@Zevell I already thought about it. I would use electron (or maybe chromium directly) to open the trade website and execute POB from its local install without the UI in some kind of service the main app would request. Perfectly doable, but I don't have the time for now, and I don't expect this to change in the coming months.

Zevell commented 2 years ago

Hey @FrancoisMentec I thought of an easier alternative. Instead of building an electron app, or any app. Make the extension allow file uploads, the users can then upload their saved build file (generated by PoB) and then you can read data from that? They are stored as XML files. The only thing is I'm not sure if the data from them would be easy enough to read/handle to make this viable.

You can find the PoB build save files in "C:\Users\%USERNAME%\Documents\Path of Building\Builds" by default.

FrancoisMentec commented 2 years ago

@Zevell I cannot paste PoB build codes (or any code) into pob.party and I could not run PoB in the browser, so having access to PoB builds would be useless. There is nothing I could do with them.

andrewkhunn commented 2 years ago

pob.party got updated at the start of 3.16 and is running Path of Building 2.12.3 as of right now. The developer of pob.party is the same as poe.trade: xyz

andrewkhunn commented 2 years ago

Thought I would let you know that, at some point, PoB.party got updated to the latest Path of Building release. Maybe it had something to do with me messaging xyz on the official forums asking him to pretty please update it.

Using the extension right now with no issues.