search

Francommit / win10_emulation_station

Emulation Station for Windows 10/11
https://francommit.com/emulationstation/
158 stars 27 forks source link

Gamecube, OneDrive option and fix for ePSXe included #18

Closed PRElias closed 5 years ago

PRElias commented 6 years ago

Hi Chris

I dont know if you are interested, but I included the dolphin Gamecube emulador

Francommit commented 6 years ago

Hey @PRElias ,

Just had a quick look through seems to be ok. Though in the spirit of full automation on this page in your link the only thing I noticed being required was:

You should now have the required game INI settings placed in the proper directory. Dolphin will look inside this directory for game-specific recommended settings.

If this is the case. We should generate the .ini ourselves so users don't have to configure anything themselves.

PRElias commented 6 years ago

Hi,

Yes, but as stated on the link that I provided, Retroarch team is planning to make that config default on future versions.

By the way, I agree with you and I will look for that.

Thanks

PRElias commented 6 years ago

Hi Chris,

I created the section for the ini file, tested, and included a tip on configuring Xbox controllers

PRElias commented 6 years ago

Chris,

Sorry, but I am not an expert on GitHub as well. I thought that only my commits made before submitting the PR will be in the package, but looking at the PR again, I guess I'm wrong.

Then, I will analyze each of them, specially that one on automatize chocolatey installation, based on your great feedback

PRElias commented 6 years ago

I reverted the commit on Choco auto-install based on your comment and I learnt that to keep my new commits separate from this PR, I would have created a new branch. Sorry about that.

I guess I finally realized what are you saying about admin privileges on script. But, the commands to install choco does not try to set that and we already ask for use an admin session...

Francommit commented 5 years ago

@PRElias this PR isn't required anymore is it? It looks like this one contains the commit that are now in master. I don't know why Github's still saying this one exists?

PRElias commented 5 years ago

I think so, sorry for the mess. I am not enough experienced in Github and caused this confusion. You can dismiss this one and I will prepare a new PR if is it necessary to correct something. Sorry again.

PRElias commented 5 years ago

Probably this problem was caused by me making changes on master...I'll avoid that in the future

ghost commented 5 years ago

Hello can you guys please include Dreamcast and Naomi stuff? also PSP plz