search

Frando / rust-faust

Easily use FAUST DSPs in Rust
Apache License 2.0
56 stars 12 forks source link

FaustBuilder: Add methods to set module and struct names, add method to set abitrary faust compiler arguments #25

Closed obsoleszenz closed 6 months ago

obsoleszenz commented 6 months ago

Closes https://github.com/Frando/rust-faust/issues/23

magnetophon commented 6 months ago

I tested set_module_name(), works perfectly, thanks!. I'm now testing .faust_arg("-double".to_string()) . Maybe https://github.com/Frando/rust-faust/pull/24 and/or https://github.com/Frando/rust-faust/pull/21 should be reverted since there is now a generic way to achieve the same thing?

obsoleszenz commented 6 months ago

I tested set_module_name(), works perfectly, thanks!. I'm now testing .faust_arg("-double".to_string()). Maybe #24 and/or #21 should be reverted since there is now a generic way to achieve the same thing?

faust_arg should be a fallback, it's nicer to have proper builder methods for this i think. This way you dont need to remember the faust cli and just can use whatever your ide recommends.

obsoleszenz commented 6 months ago

I tested set_module_name(), works perfectly, thanks!. I'm now testing .faust_arg("-double".to_string()). Maybe #24 and/or #21 should be reverted since there is now a generic way to achieve the same thing?

Better it would be to make the timeout also a builder parameter