Frank-en-stein / sipdroid

Automatically exported from code.google.com/p/sipdroid
0 stars 0 forks source link

lockscreen blocks answer call screen #1108

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Activate lockscreen with gesture
2. Call your sipdroid connected number
3. See that there is no pissibility to answer the call as it should. 

What is the expected output? What do you see instead?
Screen for answerering the call is not shown.

What version of the product are you using? On what device/operating system?
Samsung Galaxy S3 on Android 4.1.2

Which SIP server are you using? What happens with PBXes?
Sipgate.de

Which type of network are you using?
Wifi

Original issue reported on code.google.com by thimmey18 on 13 May 2013 at 6:43

GoogleCodeExporter commented 9 years ago
may be duplicate or related to issues 1137 and 1147

Original comment by Dale.DeJ...@gmail.com on 12 Dec 2013 at 12:37

GoogleCodeExporter commented 9 years ago
Actually, I suspect this may be the issue I've just run across.  Originally I 
just used a pattern lock and the answer screen shows over it on incoming call.  
However, due to annoying work policies, I had to switch to a password protected 
lockscreen and the answer screen no longer shows over it (you have to type your 
password to get to the answer call screen).

The problem seems to be the KeyguardManager won't override a password policy.  
To get a window to display above a password lock, you have to set a special 
flag.  This is the fix I've built and am working with (cant attach because 
apparently we're over our issue attachment storage quota)

---

commit 2e5ef167b377d60d5794a935b67d36119f0e3c83
Author: James Bottomley <JBottomley@Parallels.com>
Date:   Sun Dec 28 14:37:22 2014 -0800

    InCallScreen: show incoming call window over password key guard

    The KeyGuard classes can't actually disable a password lockscreen, so you have
    to give the root window a FLAG_SHOW_WHEN_LOCKED.

    Signed-off-by: James Bottomley <JBottomley@Parallels.com>

diff --git a/src/org/sipdroid/sipua/ui/InCallScreen.java 
b/src/org/sipdroid/sipua/ui/InCallScreen.java
index 5a03ac8..a8e5461 100644
--- a/src/org/sipdroid/sipua/ui/InCallScreen.java
+++ b/src/org/sipdroid/sipua/ui/InCallScreen.java
@@ -391,6 +391,10 @@ public class InCallScreen extends CallScreen implements 
View.OnClickListener, Se
        super.onCreate(icicle);

        requestWindowFeature(Window.FEATURE_NO_TITLE);
+       // set this flag so this activity will stay in front of the
+       // keyguard otherwise this window won't display if there is a
+       // password lockscreen
+       getWindow().addFlags(WindowManager.LayoutParams.FLAG_SHOW_WHEN_LOCKED);
        setContentView(R.layout.incall);

        initInCallScreen();

Original comment by jej...@googlemail.com on 28 Dec 2014 at 10:57