FrankBijnen / ExifToolGui

A GUI for ExifTool
GNU General Public License v3.0
312 stars 15 forks source link

ExifToolGUI ability to handle UNC/network path as (startup) parameter #472

Closed BorreSanders closed 1 week ago

BorreSanders commented 1 month ago

Hello Frank,

First of all, thanks for picking up on continuing ExifToolGUI development. I recently found out, and like the improvements. I also found a (for me) typical use-case that does not seem to work due to most of my pictures being on network storage. I could not find a user forum or your contact data, so I post the issue I bumped into here. Hope that's OK with you.

Issue: I'd like to be able to jump right in to some path on the network by passing the network path to the GUI executable as a parameter, formatted as UNC path. With ExifToolGUI (I tried 6.3.4.0, 64bit executable) this does not seem to work.

What works as expected: C:\Program Files\ExifToolGUI>ExifToolGui_X64.exe "%UserProfile%\pictures" Result: ExifToolGUI starts up in user picture directory

What doesn't work as expected/hoped for: C:\Program Files\ExifToolGUI>ExifToolGui_X64.exe "\\myServer\home" (UNC path) Result: ExifToolGUI starts up very slowly and ends up displaying some 'base' screen.

Is this to be a new feature or should this work?

Thanks in advance for your feedback and support!

Kind regards, Borre Sanders

P.S. I thought this used to work with v5.16, but upon verifying it turned out that actually it already didn't. I used temporary network drive mappings as a workaround.

FrankBijnen commented 1 month ago

Hello Borre, (Assume this is your first name)

Thanks for your kind words!

What you describe should work, in the ideal world. I tried to replay your scenario and was surprised by some of the results.

Frank

OK: network_ok Not Ok: Network_nok

Possible Workarounds:

single

BorreSanders commented 1 month ago

Hello Frank, thanks for your prompt investigation and response! I've found that the network node does not expand, also not on standard File Explorer in Windows (I'm running on Windows 11 Home 23H2). So I'm in the 'Not OK' situation. If I (manually) type the UNC path in File Explorer ( e.g. \\myServer\home), it does successfully navigate to the network server (NAS) there and displays the folder's contents. For ExifToolGUI using the single instance option seems to make no difference. Hope this helps to further investigate. Kind regards, Borre

FrankBijnen commented 1 month ago

Hello Borre,

Sorry for the confusion about 'single instance'. Let me clarify:

But I have more (better) news. I have created a fix. If the path is a UNC path GUI will set the root (Top item) to that path first. Thereby eliminating the need to expand the network node. To get back to the desktop click on 'Desktop' in the BreadCrumb bar on top of the filelist.

This is the download link to the V635 pre-rel. Please download, test it, and let me know what you think. https://1drv.ms/f/s!AhVJC-QzM33pknOS7KwBi09lgNql?e=n7ztFX

Frank

BorreSanders commented 1 month ago

On my 2 Windows 11 systems network node expansion does not work somehow (no error messages), neither in File Explorer nor in ExifToolGUI. I'm not sure why, since on the file server WS-Discovery is enabled, and the network is configured to enable netbios on TCP/IP. I'll look into it further some other time. Fixing this is probably most robust, but I have to figure out what's blocking this functionality first.

The preview version with the fix looks somewhat promising, i.e. shows the data in the UNC path. However the navigation structure looks a bit weird, and I could not navigate up and return to the UNC path later if I moved focus to another folder and later decide that I want to return to the view with the UNC path. Screenshot 2024-07-28 212017

FrankBijnen commented 1 month ago

Hi Borre,

I'm not convinced that fixing the 'network expansion' will solve all. Expansion works on my W10/W11 systems, and I could reproduce it. But nevertheless it's worth investigating.

Can you indicate what needs to fixed to the pre-rel to make it work for you?

Just a few quick remarks.

but I have to figure out what's blocking this functionality first.

(Windows) Firewall?

The preview version with the fix looks somewhat promising

Good to have the confirmation I'm looking at the right spot.

However the navigation structure looks a bit weird

You mean the 3 triangles? That control replaces a \ with a triangle. I agree it needs fixing, let's focus on getting it working first

I could not navigate up and return to the UNC path later.

Suppose you navigated to subfolder(s) of 'home', and want to get back. Just click on 'home'. Navigating in the Treeview should work. With the single instance setup, you can just start GUI with the path again.