FrankChen021 / bithon

An observability platform mainly for Java
Apache License 2.0
14 stars 4 forks source link

validate and optimize filter expressions #666

Closed FrankChen021 closed 9 months ago

FrankChen021 commented 9 months ago

literal expression is allowedin filter expression, however, when the literal expression(such as string literal) is converted to as a filter at the storage size, it's invalid. the error message from the storage layer confuses users.

integer literal in some cases is also invalid, e.g, only uint8 of integer literal is allowed in some storage. For those returning type of uint16/32/64, the literal expression should be turned into a comparison expression.

Besides literal expression, function expression that returns type of string is also invalid.