Using Validators for config and using false outcome instead of throwing exception

FrankGasparovic / Windows-Desktop-SSO-Node

Windows Desktop SSO Node

1 stars 3 forks source link

Using Validators for config and using false outcome instead of throwing exception #4

Closed danielfrankeicc closed 4 years ago

danielfrankeicc commented 4 years ago

Validators in config ensure that config is validated when it is configured and does not require that it is validated during each auth process
If NodeProcessException is thrown, error handling is not possible (error message, offering username/password login etc.).

Maybe useful extension

deepakgangore commented 4 years ago

Hi, I am facing issue related nodeexception where wdsso node does not fail gracefully. Looks like it has been fixed in this PR. Could you please tell me the ETA of this change appear in wdsso node?

Thanks Deepak Gangore

FrankGasparovic commented 4 years ago

Hi, I am facing issue related nodeexception where wdsso node does not fail gracefully. Looks like it has been fixed in this PR. Could you please tell me the ETA of this change appear in wdsso node?

Thanks Deepak Gangore

The PR has been merged and the issue is fixed.