FrankLiOnLine / EC601Project1

0 stars 0 forks source link

Issues in Google Vision Part #1

Open WayGang opened 6 years ago

WayGang commented 6 years ago

Hi Frank, I'm your reviewer and I've read your codes. My suggestions are: First, I think you can find a better way to deal with the GoogleVision part. You can see in my codes, I used the method '''client = vision.ImageAnnotatorClient() response = client.label_detection(image=image_descript) ...... labels = response.label_annotations''' that only a few lines codes can do the same thing. Second, I recommand you to add some conditional statements to solve the problems like, what if the Twitter user doesn't have any pictures? And what if the input user name is inconform?

FrankLiOnLine commented 6 years ago

a) What you mentioned is a method by using google cloud vision in image label detection. My version used google cloud video intelligence, which released in mid 2017 and can perform a frame to frame detection for a video. b) In my twitterAPI.py file in line 47, I used try to get image url from entity, so if there is no picture in a twitter account, it will pass it and finish searching.