search

FrankWork / conv_relation

TensorFlow implementation of Relation Classification via Convolutional Deep Neural Network
94 stars 29 forks source link

use test dataset as validation dataset? #8

Open liubingai opened 6 years ago

liubingai commented 6 years ago

Hello Frank, @FrankWork

I think you have implemented the model well. However, it seems you have made a mistake because you use test dataset as the validation dataset (which is forbidden absolutely in ML). So, I think the performance you have showed in log files is not exact.

Maybe I have misunderstood your code. Expecting your reply.

FrankWork commented 6 years ago

you are right. I used test dataset as the validation set.