search

FrankWork / fudan_mtl_reviews

TensorFlow implementation of the paper `Adversarial Multi-task Learning for Text Classification`
178 stars 40 forks source link

Performance issues in fudan_mtl_reviews/blob/master/src/inputs/util.py(P2) #21

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello,I found a performance issue in the definition of read_tfrecord , fudan_mtl_reviews/blob/master/src/inputs/util.py, dataset = dataset.map(parse_func) was called without num_parallel_calls. I think it will increase the efficiency of your program if you add this.

Here is the documemtation of tensorflow to support this thing.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.