This PR focuses on making several updates and improvements to the codebase, including changes to contract functions, event definitions, and data types.
Detailed summary:
Updated the internalType of _challengePeriod in PositionFactory.json and IPositionFactory.json from uint256 to uint64.
Exported DECIMALS and floatToDec18 functions in math.ts.
Updated the printWidth and bracketSpacing options in .prettierrc.json.
Added a new minted function in StablecoinBridge.json to track the total minted amount.
Updated the isPosition function in GeneralTest.sol to use getPositionParent instead.
Added a new Profit event in Frankencoin.json to track profits.
Updated the data type of _challengePeriod in PositionFactory.sol from uint256 to uint64.
Updated the _cubicRoot function in MathUtil.sol to include a condition for _v values between ONE_DEC18 and 10 ** 19.
Updated the _useAllowance function in ERC20.sol to include a check for INFINITY allowance.
Removed the bidNearEndOfChallenge and splitAndEnd functions from MintingHubTest.json.
Updated the getChallenge function in MintingHubTest.json to only return the challenge number.
Updated the notifyChallengeSucceeded function in IPosition.sol to remove unnecessary input parameters.
Added a new notifyChallengeAverted function in IPosition.sol.
Updated the notifyChallengeSucceeded function in Position.sol to remove unnecessary input parameters.
Updated the challengeData function in Position.sol to include additional output parameters.
Updated the reduceLimitForClone function in Position.sol to remove the exp input parameter.
Updated the tryAvertChallenge function in Position.sol to remove unnecessary input parameters.
Added a new challengeData function in IPosition.sol to retrieve challenge data.
The following files were skipped due to too many changes: abi/IPosition.json, contracts/interface/IFrankencoin.sol, abi/MintingHub.json, contracts/Equity.sol, contracts/test/MintingHubTest.sol, test/PositionTests.ts, contracts/Position.sol, contracts/Frankencoin.sol, contracts/MintingHub.sol, package-lock.json
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
PR-Codex overview
Focus of this PR:
This PR focuses on making several updates and improvements to the codebase, including changes to contract functions, event definitions, and data types.
Detailed summary:
internalType
of_challengePeriod
inPositionFactory.json
andIPositionFactory.json
fromuint256
touint64
.DECIMALS
andfloatToDec18
functions inmath.ts
.printWidth
andbracketSpacing
options in.prettierrc.json
.minted
function inStablecoinBridge.json
to track the total minted amount.isPosition
function inGeneralTest.sol
to usegetPositionParent
instead.Profit
event inFrankencoin.json
to track profits._challengePeriod
inPositionFactory.sol
fromuint256
touint64
._cubicRoot
function inMathUtil.sol
to include a condition for_v
values betweenONE_DEC18
and10 ** 19
._useAllowance
function inERC20.sol
to include a check forINFINITY
allowance.bidNearEndOfChallenge
andsplitAndEnd
functions fromMintingHubTest.json
.getChallenge
function inMintingHubTest.json
to only return the challenge number.notifyChallengeSucceeded
function inIPosition.sol
to remove unnecessary input parameters.notifyChallengeAverted
function inIPosition.sol
.notifyChallengeSucceeded
function inPosition.sol
to remove unnecessary input parameters.challengeData
function inPosition.sol
to include additional output parameters.reduceLimitForClone
function inPosition.sol
to remove theexp
input parameter.tryAvertChallenge
function inPosition.sol
to remove unnecessary input parameters.challengeData
function inIPosition.sol
to retrieve challenge data.