Frankencoin-ZCHF / frankencoin-api

MIT License
0 stars 1 forks source link

No Event "MintingUpdate" for adjust if minted is decreased #11

Closed samclassix closed 1 month ago

samclassix commented 1 month ago

Issue with state

How to replicate:

  1. Api depends on ponder indexed state and blockchain stored history to minimize fetching manual data.
  2. It was anticipated that the event "MintingUpdate" gets triggered if you adjust your position incl. minting amount.
  3. Event MintingUpdate includes uint256 minted, however, never called/triggered. never indexed.

Explanation:

Screenshot 2024-08-06 at 3 31 57 PM

Similar issue is already known with collateral transfer

Solvable?

samclassix commented 1 month ago

FIXME:

samclassix commented 1 month ago

done

luziusmeisser commented 1 month ago

Thanks for the hint. I also fixed this in the upcoming 2024 version of the smart contracts: https://github.com/Frankencoin-ZCHF/FrankenCoin/commit/e4e051a3549a4d8ef05600fd03d695bc76c48822