Frankencoin-ZCHF / frankencoin-dapp

Frankencoin Web App to interact with the Eco System
https://app.frankencoin.com/
MIT License
1 stars 4 forks source link

The app does not recognize if the wallet is connected to the wrong blockchain. #25

Closed TaprootFreak closed 4 months ago

TaprootFreak commented 7 months ago

I have tried. to exchange approx. 100 ZCHF for FPS. However, my Metamask was connected to Arbitrum and not to Ethereum.

Instead of throwing an error message, Frankencoin simply passed the command to Metamask and Metamask executed it. On the wrong blockchain 😁

Bildschirmfoto 2024-02-14 um 20 59 52 Bildschirmfoto 2024-02-14 um 21 00 02 Bildschirmfoto 2024-02-14 um 21 00 12 Bildschirmfoto 2024-02-14 um 21 07 10

It should be easy to detect an incorrect network and force a network change directly.

samclassix commented 4 months ago

you are right. Detection of the correct chain is quite important. ;)

This should fix it. https://github.com/Frankencoin-ZCHF/frankencoin-dapp/pull/35