search

FrankensteinVariorum / fv-data

TEI data for the Frankenstein Variorum project
The Unlicense
3 stars 0 forks source link

multiply-defined ID #7

Closed mdlincoln closed 5 years ago

mdlincoln commented 5 years ago

in P5-f1823_C06.xml and P5-f1831_C10.xml the id F1823_v1_055 is defined multiple times, so I get a warning when trying to parse those files

ebeshero commented 5 years ago

Thanks @mdlincoln ! That's weird--it's an @xml:id on a <pb/> (marking a page-beginning, and the page number in the 1823 edition). There's two of those in close proximity, so they can't both be right. There will be an error in the XML source code...For right now (for your purposes) and I'll check which is the real page-beginning and comment out the bad one, but that's just a temporary patch. Let me know if you spot more like that!

Note: Only the @xml:id attributes on <seg> elements mark a variant passage. I'm relieved this was on a page break, since it's likely to be a simple fix.

ebeshero commented 5 years ago

@mdlincoln I've fixed it for right now with this commit: https://github.com/PghFrankenstein/fv-data/commit/031a5ea34cdc64b2a14b332d7729590de41cbba3 Basically I checked the source photofacsimile for 1823 and noted the second <pb> was an error, so I commented it out here. I need to correct that earlier in the process, but for now this should help you continue processing.

mdlincoln commented 5 years ago

Great - this parses cleanly now.