FrankensteinVariorum / fv-postCollation

a repository for post-processing finalized collation files to prepare the Variorum edition.
2 stars 0 forks source link

Not generating spine ptrs to segs with __I, __M, and __F #35

Closed ebeshero closed 1 year ago

ebeshero commented 1 year ago

I discover that we generate empty <rdg> elements (with no <ptr> elements) in our final output Spine every time we have a <seg> in the edition files with an @xml:id containing __I, __M, and __F. Example from C21 spine: In the example, f1818, f1823, and fThomas should each contain <ptr> elements because they hold variant text, but they are empty.

 <app xml:id="C21_app208">
               <rdgGrp n="['werter.']" xml:id="C21_app208_rg1">
                  <rdg wit="#f1818"/>
                  <rdg wit="#f1823"/>
                  <rdg wit="#fThomas"/>
                  <rdg wit="#fMS">
                     <ptr target="https://raw.githubusercontent.com/FrankensteinVariorum/fv-data/master/2023-variorum-chapters/fMS_box_c57_another_chapter.xml#C21_app208-fMS"/>
                     <witDetail wit="#fMS">
                        <ptr target="https://raw.githubusercontent.com/umd-mith/sga/6b935237972957b28b843f8d6d9f939b9a95dcb5/data/tei/ox/ox-ms_abinger_c57/ox-ms_abinger_c57-0039.xml#string-range(//tei:surface[@xml:id='ox-ms_abinger_c57-0039']/tei:zone[@type='main']//tei:line[7],34,42)"/>
                        <fv:line_text xmlns:fv="https://github.com/FrankensteinVariorum">( the letters Sorrows thelettersof) Werter.</fv:line_text>
                        <fv:resolved_text xmlns:fv="https://github.com/FrankensteinVariorum">f Werter</fv:resolved_text>
                     </witDetail>
                  </rdg>
               </rdgGrp>
               <rdgGrp n="['werter.’']" xml:id="C21_app208_rg2">
                  <rdg wit="#f1831">
                     <ptr target="https://raw.githubusercontent.com/FrankensteinVariorum/fv-data/master/2023-variorum-chapters/f1831_chapter_xv.xml#C21_app208-f1831"/>
                  </rdg>
               </rdgGrp>
            </app>

In the edition files for the empty witnesses, we find cases like this (example from f1818 at this point):

<seg part="I" xml:id="C21_app206-f1818__I">
               </seg>
            <hi xml:id="novel1_letter4_chapter14_div4_div15_p6_hi2">
               <seg part="F" xml:id="C21_app206-f1818__F">Sorrows</seg> of  <seg part="I" xml:id="C21_app208-f1818__I">Werter</seg>
            </hi>
            <seg part="F" xml:id="C21_app208-f1818__F">.</seg>

I find that we have not created a way to generate URL pointers to these special <seg> elements in the P6-SpineGenerator.xsl, so I am working on that now.

This is possibly related to https://github.com/FrankensteinVariorum/fv-postCollation/issues/26

ebeshero commented 1 year ago

Solved in https://github.com/FrankensteinVariorum/fv-postCollation/pull/33/commits/dfea3b3b1effdc0421c3ba0fcc497971384d9c47 (just waiting for PR to be merged).