Open ebeshero opened 10 months ago
When working on this, make sure you first git pull
on all the repos:
(I've pushed updates to each of these over the weekend!)
Shelley-Godwin Archive links now no longer work: they all lead to "undefined" rather than to the filenames in the SGA site.
@Yuying-Jin I found two problems this weekend with updating the Variorum after a postCollation run.
1.MS: C57 Vol II Chapter 1 can be selected in the FV viewer, but displays without hotspots: https://frankensteinvariorum.org/viewer/MS/box_c57_vol_ii_chap_1/ In trying to discover the problem, I found:
Coming out of postCollation, C57 Vol II Chapter 1 file outputs with this anchor element at the top:
<anchor type="semantic" subtype="start" xml:id="fMS_box_c57_vol_ii"/>
, but it should come out as<anchor type="semantic" subtype="start" xml:id="fMS_box_c57_vol_ii_chap_i"/>
. I think you have a patch for this in the JS, so it's not really a problem.When we generate
units.json
, for some reason this does not account for the very last<app>
that contains MS content: app 621.Also, the very first app with info from the MS in the spine_C17 file has
@n = 0
, which is different from the other spine files.However, manually editing units.json to reflect the fMS range of 1 to 621 does not help to fix the rendering of the fMS. I'm not sure how to repair this problem to make the hotspots visible in the reading view on this MS chapter.
http://shelleygodwinarchive.org/sc/oxford/ms_abinger/undefined