Open ebeshero opened 1 year ago
@raffazizzi @nhammer514 Please add more notes to this issue as we're reviewing the interface!
[ ] - Be sure that next
and prev
buttons work on each page to select the previous and next chapter files in the currently selected edition. @Yuying-Jin
@Yuying-Jin @raffazizzi @nhammer514 While @djbpitt is visiting for Balisage, we've been looking at the new FV interface so far! It's very impressive! I've taken some notes just now for us to think about.
[x] Make sure that deleted passages are visible as strike-through in the reading panel for MS and Thomas
[x] Consider how we display MWS's notes (
<note>
elements) in the Thomas edition reading view[x] Display of
<note>
elements in Reading View and Side Panel:<note resp="MWS">
always display<note resp="FV-Team">
and make it optional somehow to display (show/hide)<note>
elements should display as blocks.[x] The selectors for the edition chapters in the top and bottom (with the long lists) seem fine after we navigate for a bit. (I was thinking that maybe we want all chapters to be available in panel that you can dismiss along the left-hand side (show/hide by tucking it away.) We're not sure that's really necessary--the dropdowns work well.
[ ] Do we want empty pages for the MS to appear if that's the first one a visitor selects? (Currently, we see only the first chapter that's marked with a chapter heading in the MS.) Remember, the MS is missing for the Preface and Letters I, II, III, and IV. When the MS edition is selected, should you see something in the chapter selector that indicates something is missing?
[x] * Again, with the MS: When there is no chapter marker in a unit, it's not showing up as a unit to be selected. I think we have solved this already or we began solving it: something we need to output in the JSON file that controls the edition chapter selectors.
[x] * Where the MS is totally missing (n those Letters I - IV and the passage in the middle), we don't really need the CSS shading to be so dark. Literally, yes, the edit-distance is huge because there's nothing (empty set) in the MS at this point. But it's only like that because we're missing pages of manuscript--not because of variant text.
1
on all relevant passages so these can easily be styled light in the interface.[x] Let's revisit the colors of grey for the hotspots: Is the darkest too dark (too little contrast with the text)? Maybe we can lighten up all the grey shades?
[x] * Watch what happens to spacing when clicking on a block element in the main text (like a chapter heading, or a block paragraph that's part of a long (longToken) passage of variation: On selection, we're adding spaces around the passage.
[x] Review how the sidepanel displays at the bottom of the page.