FrankerFaceZ / Add-Ons

Add-Ons are additional modules for FrankerFaceZ that provide new behaviors and ways to customize Twitch.
65 stars 58 forks source link

[Smokey's Utilities] Maintain HD Quality option causes auto-play issues #144

Open Twichigo opened 1 year ago

Twichigo commented 1 year ago

Since this commit, whenever you open a stream in a new tab, video won't start playing and stays infinitely buffering (black screen) until you pause and un-pause it. Additionally, when you are on a channel page and stream starts, it just stays black screen until you refresh the player.

Turning Maintain HD Quality off removes both issues.

Lordmau5 commented 1 year ago

Gonna @smokey019 for this one

smokey019 commented 1 year ago

what browser do you use? and do you have other extensions enabled for twitch? ie: auto point/drop claimer for twitch etc

Twichigo commented 1 year ago

what browser do you use? and do you have other extensions enabled for twitch? ie: auto point/drop claimer for twitch etc

Vivaldi, which is on Chrome engine. PC. I also use BTTV, which indeed has auto points and drop claimer built-in.

smokey019 commented 1 year ago

what browser do you use? and do you have other extensions enabled for twitch? ie: auto point/drop claimer for twitch etc

Vivaldi, which is on Chrome engine. PC. I also use BTTV, which indeed has auto points and drop claimer built-in.

gotcha i can replicate this. i can look into finding a solution soon ™️

Twichigo commented 1 year ago

Any news on this one? I have also noticed the same issue happens when you have an offline channel page open and then the stream starts - if the tab is not active, the player will stuck in the same black buffering state until you pause and un-pause it. Also, when it's in this black screen state from any cause, changing the video quality doesn't fix it, even though normally it would refresh the stream i.e. standart buffering or delay would get fixed.

smokey019 commented 1 year ago

still trying to find a fix

Taizunz commented 7 months ago

Update 1.2.1 unfortunately does not seem to have fixed this issue.

Twichigo commented 4 months ago

Still an issue to this day. Updated the opening message to include another auto-play issue that I mentioned some time ago.

smokey019 commented 4 months ago

as far as i know, there's no way to fix this for now

Twichigo commented 4 months ago

as far as i know, there's no way to fix this for now

Since this only broke after specific commit, is it possible to revert the changes or re-implement parts of the older code?

smokey019 commented 4 months ago

as far as i know, there's no way to fix this for now

Since this only broke after specific commit, is it possible to revert the changes or re-implement parts of the older code?

it didn't break after a specific commit. i tried a couple different things to get it to work and nothing seemed to actually make it work.

if you open a new browser after it crashes, it won't have this issue when you ask it to re-open tabs. but it only happens when you start a fresh browser. so it's likely something to do with the browser and not necessarily the code.

commanderroot's script also has this same issue, so there's likely nothing we can do about it. again, at least as far as i know.

the code is open source, so feel free to commit changes if you happen to find out what is causing it :)