search

FrankerFaceZ / Add-Ons

Add-Ons are additional modules for FrankerFaceZ that provide new behaviors and ways to customize Twitch.
66 stars 58 forks source link

New User Highlighter - Date calculated wrong or API issue #191

Closed lafaro closed 9 months ago

lafaro commented 9 months ago

Module Affected Add-Ons » New User Highlighter

Issue Date calculated wrong. Mapping not updated since 24th October 2023. All new Accounts after the 31th October marked as new created accounts, instead of using the setting of "last 7 days". I checked the issue on 2 other independent installations on other PCs/users, which have the same issue.

Steps to reproduce

  1. Enable Addon with default settings (mar all accounts created before 7 days)
  2. Any user account after 31th October is highlighted as new account.

Analyze File: https://github.com/FrankerFaceZ/Add-Ons/blame/master/src/new-account-highlighter/index.js

The mapping of the dropdown values uses the folloing API URL to load the calculated relative timestamps: https://ffz.0x.bot/api/mappings.json

The API delivers the following JSON at 19th November 2023:

{"1h":{"ts":1698123600,"uid":975573975},"2h":{"ts":1698120000,"uid":975562807},"4h":{"ts":1698112800,"uid":975531405},"6h":{"ts":1698105600,"uid":975494127},"12h":{"ts":1698084000,"uid":975370986},"1d":{"ts":1698105600,"uid":975494127},"2d":{"ts":1698019200,"uid":974997673},"3d":{"ts":1697932800,"uid":974410975},"4d":{"ts":1697846400,"uid":973772841},"5d":{"ts":1697760000,"uid":973204598},"6d":{"ts":1697673600,"uid":972658625},"7d":{"ts":1697587200,"uid":972021721},"30d":{"ts":1695600000,"uid":960475472},"365d":{"ts":1666656000,"uid":840241683}}

The 1 hour ts value is the timestamp 1698123600, which is Tuesday, 24. October 2023 05:00:00 UTC and not the 19th October 2023 minus 1 hour.

Assumptions

iProdigy commented 9 months ago

@1F916 could you please clear the cache again? https://github.com/FrankerFaceZ/Add-Ons/issues/115 has reappeared

1F916 commented 9 months ago

This is fixed again since 2023-11-27, as somebody on discord brought it to my attention.

There was a problem where a changed SSH host key caused the cronjob that generates those mappings to hang.

Sorry for not getting to it sooner, but I am ill at the moment and don't always get these notifications in a timely manner.

iProdigy commented 9 months ago

Hope you feel better soon! @1F916

Lordmau5 commented 9 months ago

Gonna close this seeing as it's been resolved :)