search

FrankerFaceZ / Add-Ons

Add-Ons are additional modules for FrankerFaceZ that provide new behaviors and ways to customize Twitch.
68 stars 58 forks source link

Chatterino Badges fix #240

Closed relaxoo closed 2 months ago

relaxoo commented 2 months ago

added: corsproxy to chatterino badges to fix the api response

Lordmau5 commented 2 months ago

Bit late to this, but would you mind upping the version number as well?

relaxoo commented 2 months ago

@Lordmau5 is it possible to change the author cause the current author wasnt active for such a long time

Lordmau5 commented 2 months ago

Okay so after talking it through with Stendec we think the best approach would be is to try and reach out to the Chatterino developers and ask them if they could add the required CORS headers to their API response.

Would it be possible for you to reach out to them and ask? Feel free to link them to this pull request as well if you want

As for updating the author field, we'd rather you leave that untouched, especially seeing as your PR is basically a one-line fix. If there are more issues coming up in the future with this addon and you'd like to keep updating it you can then add yourself into the maintainer field like I did for the 7TV Emotes addon here https://github.com/FrankerFaceZ/Add-Ons/blob/master/src/7tv-emotes/manifest.json#L12