Closed BallM4788 closed 3 years ago
BallM4788
commented
3 years ago UPDATE: I've since created a separate, fresh profile in Waterfox Classic with only FFZ installed, and the bug still occurs even in that state. If it helps, this all started several months ago (I want to say early January, but I can't remember exactly); prior to that, everything worked perfectly.
SirStendec
commented
3 years ago FrankerFaceZ targets modern browsers, and at times may utilize HTML, CSS, and/or JavaScript features that have been added to all widely used browsers.
Waterfox Classic is a fork of a very old version of Firefox and, as such, does not necessarily support modern features. Please consider switching to a more recent browser. I know that Waterfox has a non-classic version which is a much more up to date fork of Firefox.
Going into specifics, the error in your logs is
core: SyntaxError: invalid regular expression flag ÿ Skipping ./chat/index.jsThis indicates a bug in your browser's JavaScript engine which was also a bug in Firefox. The Firefox issue (https://bugzilla.mozilla.org/show_bug.cgi?id=1452619) was closed in April of 2018.
Again, please consider switching to a different browser. If you have one bug from 2018, what else do you have?
BallM4788
commented
3 years ago FrankerFaceZ targets modern browsers, and at times may utilize HTML, CSS, and/or JavaScript features that have been added to all widely used browsers.
Waterfox Classic is a fork of a very old version of Firefox and, as such, does not necessarily support modern features. Please consider switching to a more recent browser. I know that Waterfox has a non-classic version which is a much more up to date fork of Firefox.
Going into specifics, the error in your logs is
core: SyntaxError: invalid regular expression flag ÿ Skipping ./chat/index.jsThis indicates a bug in your browser's JavaScript engine which was also a bug in Firefox. The Firefox issue (https://bugzilla.mozilla.org/show_bug.cgi?id=1452619) was closed in April of 2018.
Again, please consider switching to a different browser. If you have one bug from 2018, what else do you have?
And again, as I stated in the post just above yours, FFZ was working FINE in this browser up until a few months ago. And no, I hadn't just updated the browser or anything else when it stopped working. I accept that you aren't going to fix it, and I'm not saying there aren't problems with Waterfox, but I am adamant that it was a change on FFZ's end that caused it to stop working. After all, the only thing the extension and userscript do is fetch an external JS file from the FFZ CDN, and if nothing changed on my end when FFZ stopped working for me, then that leaves something that changed on the external script which broke on Waterfox but not on other browsers as the culprit.
BallM4788
commented
3 years ago @SirStendec just an update: a new waterfox classic update seems to have resolved the problem. Apologies if my previous post came off as hostile. That was not my intent, but I can see now that it could come off as confrontational.
Here is what I was getting in JSFiddle before the update:
And here's what I get now:
BallM4788
commented
3 years ago @SirStendec I'm back. To start off: no this isn't a plea for you to reopen the issue (I know you aren't going to), but I would appreciate it if you read this.
Anyway, Waterfox Classic got another update (2021.04.2) that rebroke FFZ. I'm in agreement with you that the problem is not with FFZ. The strange thing is that, in my testing, WF Classic only seems to fail regex when the eval() function is involved (see 1st pic in the previous post), yet eval() doesn't seem to be anywhere in the FFZ source code. I should also note that whitelist and blacklist regex patterns work fine for me in BetterTTV. Are there any background components or dependencies that use eval()? I want to be fairly positive of what's causing FFZ to not load before I open up an issue on the Waterfox github.
I'm also just noticing that I forgot to include a stack trace in my initial post, so here it is:
FFZ [core]: SyntaxError: invalid regular expression flag ÿ
Stack trace:
Emoji@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:128282
register@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:35709
inject@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:34134
Chat@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:498844
register@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:35709
populate@https://cdn.frankerfacez.com/script/avalon.js?_=1619550473222:2:36545
Skipping ./chat/index.jsspecifically failing on this.splitter=h()(),, where character 128282 is h. The corresponding line in the source code is here.
SirStendec
commented
3 years ago eval() isn't being used anywhere that I am aware of, though it's not impossible that a dependency could be using it. I do use the RegExp constructor in places, though not at the particular code in that traceback.
Firefox had the same issue, way back, and it was fixed when the issue I linked was closed. That's all I can really say about it. I don't have perfect memory of when it happened.
If you look at the library FFZ is using there, it's this file which is basically unchanged during webpack's compilation: https://github.com/mathiasbynens/emoji-regex/blob/main/es2015/index.js
Describe the bug FFZ fails to initialize in chat. Occurs on both main page and popout chat. FFZ Control Center can be opened as well as all the setting menus, but log uploading always fails and the upload button remains greyed out until page is reloaded. Occurs in both the browser extension and the userscript.
To Reproduce Go to any page where a chatbox is present (stream, video, clip, popout chat, etc.).
Expected behavior FFZ should initialize in chat successfully, and log uploading should occur successfully.
Screenshots
Environment (please complete the following information):
As far as I know, the only ones of these that can interact with webpages are Polly, Redirector, Stylus, uBlock Origin, and Violentmonkey. Neither Stylus nor Redirector are configured to do anything on Twitch, and the only userscript running on Twitch is FrankerFaceZ. Disabling uBlock and Polly made no difference.
FFZ Logs (via FFZ Control Center > Home > Feedback >> Log):
Additional context I have also tried a hard reset on my FFZ preferences and deleting all Twitch cookies. Neither made a difference.