Improve pykorm - Githubissues

Frankkkkk / pykorm

A python 🐍 kubernetes ☸️ ORM 🚀. Very useful when writing operators for your CRDs with Kopf.

MIT License

73 stars 4 forks source link

Improve pykorm #11

Closed AnyISalIn closed 4 years ago

AnyISalIn commented 4 years ago

Hi, Frank.

I found this project on GitHub two months ago. It is excellent and helped me build a PaaS project based on Kubernetes

In the process of using it, I also modified some codes to support the following functions

List field nesting & dictionary field nesting
Multi-cluster support
Label Filter & Field Selector Filter
editable & required and other verification
Kubernetes native API support

Here are some usage examples, https://github.com/AnyISalIn/pykorm/tree/master/examples

It works well in my project, Can you see what features can be merged into the master branch?

Frankkkkk commented 4 years ago

Hi @AnyISalIn ! Thanks for this huge MR !

I'll take a look into it this week and I'll keep you up to date.

Cheers and thanks ! Frank

AnyISalIn commented 4 years ago

There may be some differences. I replaced the original dot with the @ symbol because, in some annotation scenarios, it seems to encounter some problem，I hope this PR can provide you with some help，Not necessarily need to merge

Frankkkkk commented 4 years ago

I had some time to work on it today. I've included your changes in MR https://github.com/Frankkkkk/pykorm/pull/13 . It's still not finished but it should turn out fine :-).

PS: For now I haven't added the NestedFields and I've corrected a small bug when calling query.filter_by in different calls (https://github.com/Frankkkkk/pykorm/pull/13/files#diff-09fe136d8dc08ef90288da205e925789b0594f2c4286b664c73b3bca8299b8fcR24)

I'll keep you up to date,

Cheers

Frankkkkk commented 4 years ago

Hi, I'm closing the MR as it has been replaced by #14 and #17 Have a nice week, Frank