🔧 Support Dict & List Nested Field

Frankkkkk / pykorm

A python 🐍 kubernetes ☸️ ORM 🚀. Very useful when writing operators for your CRDs with Kopf.

MIT License

73 stars 4 forks source link

🔧 Support Dict & List Nested Field #17

Closed AnyISalIn closed 3 years ago

AnyISalIn commented 4 years ago

Hi, this is PR for https://github.com/Frankkkkk/pykorm/issues/16

Plan to support native Open API structure integration, This will support the reference of Kubernetes native Model.

AnyISalIn commented 4 years ago

Hi Frank, thank you for the code review. This helped me a lot, Based on your comment, I submitted a new code

Frankkkkk commented 3 years ago

Hi @AnyISalIn Looks quite good to me ! There's just 2 minor changes that I'd like (newline + kube fixture in test_model_setattr) but if you're okay with it I can edit your commit and then merge-it ?

Let me know, Cheers

AnyISalIn commented 3 years ago

@Frankkkkk No problem!

Frankkkkk commented 3 years ago

I squashed your commits + added another small to support the failing test. Should be good :+1: