Closed AnyISalIn closed 3 years ago
Hi Frank, thank you for the code review. This helped me a lot, Based on your comment, I submitted a new code
Hi @AnyISalIn Looks quite good to me !
There's just 2 minor changes that I'd like (newline + kube fixture in test_model_setattr
) but if you're okay with it I can edit your commit and then merge-it ?
Let me know, Cheers
@Frankkkkk No problem!
I squashed your commits + added another small to support the failing test. Should be good :+1:
Hi, this is PR for https://github.com/Frankkkkk/pykorm/issues/16
Plan to support native Open API structure integration, This will support the reference of Kubernetes native Model.