Improve Auto Hide functionality

fofajardo commented 6 years ago

Main Point

AiOS issue: AddonLab/AiOS#18

Could you add a switch for auto-hide?

[x] Auto show & auto hide

[x] Auto show, not auto hide

~~Auto show. If later user click mouse within the side bar area, do not auto hide. Otherwise (if the side bar is never focused), auto hide.~~

This is the feature I'm really missing..... (Yeah... a very great feature in an old but really good browser Sleipnir 2)

Second Point

[x] Allow the sidebar switch to be completely invisible while retaining its function (like Sidebar Auto Show/Hide does)
[x] Automatically hide real sidebar switch when this feature is enabled
[x] Resolve remaining conflicts (*)

Others

[x] Convert 'hide sidebar if the mouse cursor is:' option to a dropdown menu and make it available by default (not hidden in advanced mode)

sergeevabc commented 6 years ago

Dear @FranklinDM, could you be so kind to make white border (which is shown when panel is hidden) optional? Currently I have to use Sidebar Auto Show/Hide extension which has no such visual annoyance.

PeterTriac commented 6 years ago

@FranklinDM Thanks! for TGS; I am leaving the sinking FF-ESR ship now it becomes a Trabant-browser... When my mouse touch the left-edge of the screen, the sidebar appears. I would like the sidebar NOT to disappear afterwards when the mouse does other things. So the sidebar has to stay visible while doing other browsing-things. Than.. my mouse touch the left-edge of the screen again and the sidebar has to disappear again. I think this is an later-version option..? (or I am blind ? ;-) (I use AiOS for 10+ years).. "it saved my live" ;-) Sorry if other people above are meaning the same issue.. Englisch is not my native language.. (Latest Pale Moon, Win. 10 64b).

fofajardo commented 6 years ago

@PeterTriac Noted, this is already in the list of tasks for part 1. @sergeevabc Added to Part2 of the task list.

fofajardo commented 6 years ago

@PeterTriac sorry if I kind of misunderstood, but this is actually already available in the current version (1.0.4) as of the time of writing:

You need to enable advanced mode first via the bottom-left settings button: capture2

Then under the General tab, click the Sidebar Switch tab and under Appearance... capture3

Select the is held on sidebar switch option capture

PeterTriac commented 6 years ago

Thanks , for your anser !! I am blind ;-) I overlooked the "Advanced Mode" I hope, Pale Moon will work for ever.. ;-) (Will be difficult..)

There has to be an "old fasion adjustable browser" with FF<57 "old extentions". Maybe Mozilla can make some money with Firefox ESR 52 . 5 , 6 , 7 , 8 , 9 , 10 , 11 ,12 , 13 , 14 , 15 ,16 , 17 , ... ;-) I go to bed for now ( 04:16 ...

  From: Franklin DM <notifications@github.com>

To: FranklinDM/TGS TGS@noreply.github.com Cc: PeterTriac piet_in_2007@yahoo.com; Mention mention@noreply.github.com Sent: Tuesday, November 7, 2017 8:15 AM Subject: Re: [FranklinDM/TGS] Improve Auto Hide functionality (#27)

@PeterTriac sorry if I kind of misunderstood, but this is actually already available in the current version (1.0.4) as of the time of writing:You need to enable advanced mode first via the bottom-left settings button: Then under the General tab, click the Sidebar Switch tab and under Appearance... Select the is held on sidebar switch option — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sergeevabc commented 6 years ago

@FranklinDM, did you get a chance to look into Part 2?

fofajardo commented 6 years ago

@sergeevabc Yes, I did. The initial commit for the feature is already completed (locally, cant find time to update the GitHub repo) and will try to fix a small conflict with the auto hide feature. When this is all finished, v1.0.5 will be released.

sergeevabc commented 6 years ago

Thank you, sir.

I click “Toggle sidebar automatically” to keep sidebar opened, but it adds unnecessary border when the invisible switch is used.

Also it would be convenient to have “Options…” in “[gear_icon] Tools…” or somewhere else in the sidebar, don’t you think?

Delay works unexpectedly. I set it to 1000 ms to avoid showing sidebar when cursor briefly touches the screen border, nonetheless the sidebar is displayed, just 1 second after.

fofajardo commented 6 years ago

@sergeevabc Can you test and try installing this one? (You need to remove the .zip from the end of the file name) TGS-v105-1a.xpi.zip

There is already an Options menu item in the sidebar, via the panel list: capture

sergeevabc commented 6 years ago

Delay works as expected now, however I am surprised you use the same value to show and to hide the sidebar. The former is meant to avoid brief touches on a trigger area, hence hundreds+ ms, but the latter is hardly desirable by everyone, hence a way to set it to 0 ms is expected. For example, I open a link from bookmarks, then I put the cursor away to hide the sidebar, yet have to wait until the delay ends.

As for lack of Options menu item and unnecessary border, I invite you to watch this GIF to grasp the crux:

fofajardo commented 6 years ago

There is a menu item for the options in the panel menu by default. Please check if you have these 2 boxes checked in the Options window (can be launched by Ctrl+Shift+F4), under the Menus category. capture Which should appear like this: capture4

The unnecessary border (or the sidebar switch) doesn't appear if auto-hide is enabled (u can permanently hide that by setting its width to 0 in the advanced settings) and the reason why options won't be placed in the Tools menu because it is already available via the menu above ^ (if you have it checked) and it is for a specific panel's functions (Bookmarks, History, MultiPanel) only.

A separate delay for hide + show may be considered in the next release (probably 1.0.6), I'll inform here if I do.

sergeevabc commented 6 years ago

Please check if you have these 2 boxes checked in the Options window under the Menus category

OK, works now.

The unnecessary border (or the sidebar switch) doesn't appear if auto-hide is enabled

GIF was recorded with auto-hide enabled and invisible switch enabled, but even so the border becomes visible when “Toggle sidebar automatically” is clicked.

fofajardo commented 6 years ago

@sergeevabc Can you try the latest release, v1.0.6?

sergeevabc commented 6 years ago

I see the progress now, yet it’s still buggy. For example, press F11 to switch to full screen, then press again, then… sidebar no longer responds.

fofajardo commented 6 years ago

The fullscreen issue is separate from this one — it doesn't save the previous state properly (remove the SB switch) and deserves its own issue.

sergeevabc commented 6 years ago

Also, it’s not convenient that you hardcoded mouse clicks to control the sidebar. For example, I use middle click to open a bookmark in a background tab and sometimes accidentally miss, but then the superfluous toolbar is shown. Let alone large tooltips, especially one which pops up when I touch the screen border.

How to disable all that stuff?

sergeevabc commented 6 years ago

Another bug. Hide toolbar inside sidebar, close sidebar, then right click somewhere next to addressbar and invoke Customize window, close it, then open sidebar… its toolbar has become visible for no reason.

fofajardo commented 6 years ago

@sergeevabc Sorry for the late reply.

The big tooltip for the sidebar switch can be disabled by setting extensions.aios.switchtip to false. (#30)
The toolbar & sidebar appearing when Customize mode is enabled is intentional as it avoids another bug (a workaround). I think I can add code that restores the previous state when exiting customize mode.
I'll try to add an option to disable/configure clicks on the invisible sidebar switch.

FranklinDM / TGS