FranklinDM / TGS

Sidebar control with award-winning user experience!
GNU General Public License v2.0
17 stars 4 forks source link

In Pale Moon, "Automatic Updates: Off" extensions are pre-checkmarked for updating after manual update check in TGS #70

Open MartinPC opened 3 years ago

MartinPC commented 3 years ago

I'm currently running:

NOTE: I'm using the Splashed! extension as an example here because it's the only example I currently have..

I don't want to update Splashed! yet, since the latest version doesn't support my Windows scaling settings. Accordingly, I changed its Automatic Updates setting to "Off."

In Basilisk, I have no problem at all with unwanted Splashed! updates, whether after an automatic extension-update check, a manual check run from Basilisk's about:addons page, or a manual check run from The Good ol' Sidebar's Add-ons sidebar.

In Pale Moon, I have no problem with the first two checks (automatic, and manual from the about:addons page), but if I run a manual check from TGS's Add-ons sidebar and then view available updates, the unwanted Splashed! 1.2.3 update is pre-checkmarked to be included in Update. (Basilisk handles this differently.)

Pre-enabling updates that have been marked "automatic updates: off" could cause users who aren't paying attention to accidentally install an update they don't want. It hasn't happened to me yet (though I can easily see how it could), and having to downgrade an extension is a fairly minor hassle, but I nonetheless think it would be better not to pre-checkmark updates for which automatic updating has been disabled. If users have changed their minds and want to update, they should be required to affirmatively enable the "Include in Update" option themselves.

I know this is a pretty minor issue, but if it's an easy fix -- why not?

Thanks, Franklin, for your work in maintaining, carrying forward, and extending a really handy extension. And Splashed! may not be as "useful" as TGS, but I'm enjoying that, too!