Inventory indices get reset regardless of the settings

FrankvdStam / SoulSplitter

A livesplit plugin for souls-games

GNU General Public License v3.0

40 stars 8 forks source link

Inventory indices get reset regardless of the settings #6

Closed AndrovT closed 1 year ago

AndrovT commented 1 year ago

Steps to reproduce:

Uncheck "Reset inventory indices" in Dark Souls 1 settings
Equip and unequip something that's not at the top of the list
Start and reset splits
Try to equip something in the same slot as before, it now defaults to the top on the list

Expected behavior:

Only reset indices when checkbox is checked

FrankvdStam commented 1 year ago

Thanks for letting me know, am unfortunately not able to reproduce. It is being checked for here: https://github.com/FrankvdStam/SoulSplitter/blob/8a6451491a820fc6eb30f5c664d72ea39656bf07/src/SoulSplitter/Splitters/DarkSouls1Splitter.cs#L111

Are you sure this is actually soulsplitter causing a reset? I did notice some people had Capitaine's timer added to their livesplit layout, which also can reset the indices. Can you check to make sure you only have 1 timer active?

FrankvdStam commented 1 year ago

@AndrovT?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.