search

Frannsoft / FrannHammer

Restful api for Smash 4 and Ultimate frame data as told by KuroganeHammer.
MIT License
42 stars 0 forks source link

The majority of the base Scrape logic in AttributeScraper needs to be pulled out and moved into external service classes #277

Closed Frannsoft closed 5 years ago

Frannsoft commented 5 years ago

Almost all of the logic for pulling character attribute data is located in this one abstract class. This is making it much more difficult than it should be to add new attribute scrapers for things that aren't uniform (e.g., Techs, Trips page).

Instead of having this logic in an abstract base class it should be pieced out into smaller service classes so I can more easily piece together the parts I need for new attribute scrapers.

Frannsoft commented 5 years ago

Took a different approach to reducing clutter with - https://github.com/Frannsoft/FrannHammer/commit/769d85d92ab23d4a79e60cf94e1fc8dd93e5d36a