search

Frannsoft / FrannHammer

Restful api for Smash 4 and Ultimate frame data as told by KuroganeHammer.
MIT License
42 stars 0 forks source link

Missing damage values for moves with different damage on ground/air only hitboxes #292

Closed rubendal closed 5 years ago

rubendal commented 5 years ago

Move normal base damage data isn't extracted correctly from the site when it has ground/air only hitboxes

Example:

Fox Utilt image

image

Fox Utilt (Late) and Ryu/Ken Dair also have this issue

Frannsoft commented 5 years ago

@rubendal I just pushed a potential fix for this in https://github.com/Frannsoft/FrannHammer/commit/e219fb417967dc4630f1dbb4ab6be52db7c18746 and https://github.com/Frannsoft/FrannHammer/commit/f7692326ea1e849ea149921d04a011063198c3d7. Let me know if you still see the issue.

Nice catch!

rubendal commented 5 years ago

Moves affected by the issue are now displaying normal base damage correctly

Thanks!